-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18916. Exclude all module-info classes #6131
Conversation
💔 -1 overall
This message was automatically generated. |
@ayushtkn @steveloughran this issue is affecting a number of backport PRs that I have made for branch3.3. The idea here is to get this PR merged to trunk and backported to branch3.3. An example broken build (a PR targeted to branch3.3) - https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/3/artifact/out/patch-javadoc-root.txt |
Why does these issues don't happen on trunk, There must be some commit present in trunk which prevents these, can we just backport that ticket? |
@ayushtkn the thing is that more and more jars are having module-info classes added to them. To have the hadoop build choose 2 sets of coordinates and ignore the rest seems like a bad idea. I've wasted tonnes of time on 3.3 builds recently and am not going to spend any more time on them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, to me this change looks fair enough, we need this, every second dependency upgrade is breaking on branch-3 & if we don't find a way, branch-3 would stop getting some relevant changes....
I am good to commit this, but good if get one more approval
1148f5d
to
0e22fd0
Compare
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1
…6131) Removes java9 and java11 from all modules pulled into the hadoop-client and hadoop-client-minicluster modules. Contributed by PJ Fanning
…6188) Removes java9 and java11 from all modules pulled into the hadoop-client and hadoop-client-minicluster modules. Contributed by PJ Fanning
…6131) Removes java9 and java11 from all modules pulled into the hadoop-client and hadoop-client-minicluster modules. Contributed by PJ Fanning
Description of PR
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?