-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-10901. Permission checking error on an existing directory in LogAggregationFileController#verifyAndCreateRemoteLogDir #3355
Conversation
… LogAggregationFileController. Create a temporary file with proper ownership to see if the underlying file system supports chmod. When the log directory was already created, but with a different user, there was an exception in the log: org.apache.hadoop.security.AccessControlException: Permission denied. user=yarn is not the owner of inode=/tmp/logs because the setPermission checked the ownership of the given path. Change-Id: I7c7908b7ec815501337daaf7a2253a11d79afc8c
🎊 +1 overall
This message was automatically generated. |
Thanks @tomicooler for working on this. The commit LGTM, +1 from my side, once you fix the checkstyle issues. :) |
…tory in LogAggregationFileController. Change-Id: Id48d073d036b939236f73b2755c2e4e8c3c4227a
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the checkstyle fixes, +1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomicooler Thanks for working on this.
Latest patch LGTM, committed to trunk.
Thanks @brumi1024 for the review.
.../java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java
Show resolved
Hide resolved
.../java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java
Show resolved
Hide resolved
…AggregationFileController#verifyAndCreateRemoteLogDir (apache#3355) Co-authored-by: Tamas Domok <tdomok@cloudera.com>
…AggregationFileController#verifyAndCreateRemoteLogDir (apache#3355) Co-authored-by: Tamas Domok <tdomok@cloudera.com> Change-Id: I9584b319cbffa3b0bafccddb6d53c05e92ea0d2c
…AggregationFileController#verifyAndCreateRemoteLogDir (apache#3355) Co-authored-by: Tamas Domok <tdomok@cloudera.com>
…ctory in LogAggregationFileController#verifyAndCreateRemoteLogDir (apache#3355) Co-authored-by: Tamas Domok <tdomok@cloudera.com> (cherry picked from commit 5e16689) Change-Id: I128d2f9a0bbb103146560dc8c13107e62a783641
… LogAggregationFileController.
Create a temporary file with proper ownership to see if the underlying
file system supports chmod.
When the log directory was already created, but with a different user,
there was an exception in the log:
org.apache.hadoop.security.AccessControlException: Permission denied.
user=yarn is not the owner of inode=/tmp/logs
because the setPermission checked the ownership of the given path.
Change-Id: I7c7908b7ec815501337daaf7a2253a11d79afc8c
Description of PR
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?