Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARN-10901. Permission checking error on an existing directory in LogAggregationFileController#verifyAndCreateRemoteLogDir #3410

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

tomicooler
Copy link
Contributor

…AggregationFileController#verifyAndCreateRemoteLogDir (#3355)

Co-authored-by: Tamas Domok tdomok@cloudera.com
Change-Id: I9584b319cbffa3b0bafccddb6d53c05e92ea0d2c

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…AggregationFileController#verifyAndCreateRemoteLogDir (apache#3355)

Co-authored-by: Tamas Domok <tdomok@cloudera.com>
Change-Id: I9584b319cbffa3b0bafccddb6d53c05e92ea0d2c
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 8m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.2 Compile Tests _
-1 ❌ mvninstall 27m 47s /branch-mvninstall-root.txt root in branch-3.2 failed.
+1 💚 compile 0m 36s branch-3.2 passed
+1 💚 checkstyle 0m 29s branch-3.2 passed
+1 💚 mvnsite 0m 41s branch-3.2 passed
+1 💚 javadoc 0m 48s branch-3.2 passed
+1 💚 spotbugs 1m 47s branch-3.2 passed
+1 💚 shadedclient 15m 14s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 40s the patch passed
+1 💚 compile 0m 32s the patch passed
+1 💚 javac 0m 32s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 22s the patch passed
+1 💚 mvnsite 0m 35s the patch passed
+1 💚 javadoc 0m 41s the patch passed
+1 💚 spotbugs 1m 56s the patch passed
+1 💚 shadedclient 16m 46s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 3m 52s hadoop-yarn-common in the patch passed.
+1 💚 asflicense 0m 27s The patch does not generate ASF License warnings.
81m 20s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3410/1/artifact/out/Dockerfile
GITHUB PR #3410
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux d92c766c9c96 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.2 / 034fc01
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3410/1/testReport/
Max. process+thread count 305 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3410/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Change-Id: I68b4a3cdc16bc847371575135ccbafe36228edeb
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.2 Compile Tests _
+1 💚 mvninstall 28m 16s branch-3.2 passed
+1 💚 compile 0m 37s branch-3.2 passed
+1 💚 checkstyle 0m 29s branch-3.2 passed
+1 💚 mvnsite 0m 42s branch-3.2 passed
+1 💚 javadoc 0m 50s branch-3.2 passed
+1 💚 spotbugs 1m 46s branch-3.2 passed
+1 💚 shadedclient 15m 11s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 40s the patch passed
+1 💚 compile 0m 32s the patch passed
+1 💚 javac 0m 32s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 23s the patch passed
+1 💚 mvnsite 0m 35s the patch passed
+1 💚 javadoc 0m 39s the patch passed
+1 💚 spotbugs 1m 52s the patch passed
+1 💚 shadedclient 16m 25s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 3m 51s hadoop-yarn-common in the patch passed.
+1 💚 asflicense 0m 26s The patch does not generate ASF License warnings.
73m 27s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3410/2/artifact/out/Dockerfile
GITHUB PR #3410
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 72f53182a24d 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.2 / 62715ad
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3410/2/testReport/
Max. process+thread count 305 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3410/2/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@brumi1024 brumi1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomicooler thanks for the backport, LGTM (non-binding)

@szilard-nemeth
Copy link
Contributor

@tomicooler Thanks for working on this backport.
Latest patch LGTM, committed to branch-3.2.
Thanks @brumi1024 for the review.

@szilard-nemeth szilard-nemeth changed the title YARN-10901. Permission checking error on an existing directory in Log… YARN-10901. Permission checking error on an existing directory in LogAggregationFileController#verifyAndCreateRemoteLogDir Sep 14, 2021
@szilard-nemeth szilard-nemeth merged commit 478d2f2 into apache:branch-3.2 Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants