Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-17711. Fix divide by zero in LoadBalancingKMSClientProvider. #3048

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+8 −6
Open

HADOOP-17711. Fix divide by zero in LoadBalancingKMSClientProvider. #3048

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f554b83
Fix divide by zero in LoadBalancingKMSClientProvider
yiyuaner May 25, 2021
ddb8f39
Check length of providers in the constructor
yiyuaner May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@ private <T> T doOp(ProviderCallable<T> op, int currPos,
}

private int nextIdx() {
if (providers.length == 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yiyuaner for reporting the issue. Should we check providers.length in constructor as there are many other places assumes providers.length is not 0.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I have moved the checks to the constructor.

throw new IOException("No providers configured !");
}

while (true) {
int current = currentIdx.get();
int next = (current + 1) % providers.length;
Expand Down