-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-17711. Fix divide by zero in LoadBalancingKMSClientProvider. #3048
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@@ -233,6 +233,10 @@ private LoadBalancingKMSClientProvider(URI uri, | |||
} | |||
|
|||
private int nextIdx() { | |||
if (providers.length == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yiyuaner for reporting the issue. Should we check providers.length in constructor as there are many other places assumes providers.length is not 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I have moved the checks to the constructor.
💔 -1 overall
This message was automatically generated. |
This pr fixes the issue here.