Skip to content

HADOOP-16835. Recover from all failures loading openssl native libs. #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

HADOOP-16835. Recover from all failures loading openssl native libs. #1827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...adoop-common/src/main/java/org/apache/hadoop/security/ssl/DelegatingSSLSocketFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,15 @@ private void initializeSSLContext(SSLChannelMode preferredChannelMode)
LOG.debug("Failed to load OpenSSL. Falling back to the JSSE default.");
ctx = SSLContext.getDefault();
channelMode = SSLChannelMode.Default_JSSE;
} catch (Exception e) {
Copy link
Contributor

@sahilTakiar sahilTakiar Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove the catch block for the NoSuchAlgorithmException and just let all exceptions be handled by the same block? these changes look useful for the NoSuchAlgorithmException as well

// other problems, such as mismatch between the native libraries and
// wildfly JARReal. Do warn here and then fall back.
LOG.warn("Failed to load OpenSSL. Falling back to the JSSE default: {}",
e.toString());
// with the full stack trace at debug level
LOG.debug("Problem in wildfly/openssl", e);
ctx = SSLContext.getDefault();
channelMode = SSLChannelMode.Default_JSSE;
}
break;
case OpenSSL:
Expand Down Expand Up @@ -294,4 +303,4 @@ private String[] alterCipherList(String[] defaultCiphers) {
ciphers = preferredSuits.toArray(new String[0]);
return ciphers;
}
}
}