Skip to content

Conversation

@steveloughran
Copy link
Contributor

@steveloughran steveloughran commented Jan 31, 2020

Fallback is the same as that for a no-algorithm, the difference this is logged. That's because this a sign of a more serious problem and I think we do need it in the logs.

Change-Id: I6bdf8ac7a2a8ee82eda3eadac20f03888af24496
@steveloughran
Copy link
Contributor Author

ran the abfs tests; failures fixed in #1821 and the "no http support " test, otherwise all good

@steveloughran
Copy link
Contributor Author

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 18m 9s trunk passed
+1 💚 compile 16m 33s trunk passed
+1 💚 checkstyle 0m 48s trunk passed
+1 💚 mvnsite 1m 22s trunk passed
+1 💚 shadedclient 14m 55s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 29s trunk passed
+0 🆗 spotbugs 2m 3s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 1s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 46s the patch passed
+1 💚 compile 15m 50s the patch passed
+1 💚 javac 15m 50s the patch passed
+1 💚 checkstyle 0m 50s the patch passed
+1 💚 mvnsite 1m 25s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 12m 44s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 32s the patch passed
+1 💚 findbugs 2m 9s the patch passed
_ Other Tests _
+1 💚 unit 9m 18s hadoop-common in the patch passed.
+1 💚 asflicense 0m 52s The patch does not generate ASF License warnings.
102m 31s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1827/1/artifact/out/Dockerfile
GITHUB PR #1827
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f613f926a1ad 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / bf8686f
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1827/1/testReport/
Max. process+thread count 1392 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1827/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

LOG.debug("Failed to load OpenSSL. Falling back to the JSSE default.");
ctx = SSLContext.getDefault();
channelMode = SSLChannelMode.Default_JSSE;
} catch (Exception e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove the catch block for the NoSuchAlgorithmException and just let all exceptions be handled by the same block? these changes look useful for the NoSuchAlgorithmException as well

@steveloughran
Copy link
Contributor Author

superceded by #1948

@steveloughran steveloughran deleted the s3/HADOOP-16835-wildfly branch October 15, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants