HADOOP-16637. Fix findbugs warnings in hadoop-cos.

hadoop-cloud-storage-project/hadoop-cos/src/main/java/org/apache/hadoop/fs/cosn/BufferPool.java

@@ -63,32 +63,27 @@ private BufferPool() {
 
   private File createDir(String dirPath) throws IOException {
     File dir = new File(dirPath);
-    if (null != dir) {
-      if (!dir.exists()) {
-        LOG.debug("Buffer dir: [{}] does not exists. create it first.",
-            dirPath);
-        if (dir.mkdirs()) {
-          if (!dir.setWritable(true) || !dir.setReadable(true)
-              || !dir.setExecutable(true)) {
-            LOG.warn("Set the buffer dir: [{}]'s permission [writable,"
-                + "readable, executable] failed.", dir.getAbsolutePath());
-          }
-          LOG.debug("Buffer dir: [{}] is created successfully.",
-              dir.getAbsolutePath());
-        } else {
-          // Once again, check if it has been created successfully.
-          // Prevent problems created by multiple processes at the same time.
-          if (!dir.exists()) {
-            throw new IOException("buffer dir:" + dir.getAbsolutePath()
-                + " is created unsuccessfully");
-          }
+    if (!dir.exists()) {
+      LOG.debug("Buffer dir: [{}] does not exists. create it first.",
+          dirPath);
+      if (dir.mkdirs()) {
+        if (!dir.setWritable(true) || !dir.setReadable(true)
+            || !dir.setExecutable(true)) {
+          LOG.warn("Set the buffer dir: [{}]'s permission [writable,"
+              + "readable, executable] failed.", dir.getAbsolutePath());
         }
+        LOG.debug("Buffer dir: [{}] is created successfully.",
+            dir.getAbsolutePath());
       } else {
-        LOG.debug("buffer dir: {} already exists.", dirPath);
+        // Once again, check if it has been created successfully.
+        // Prevent problems created by multiple processes at the same time.
+        if (!dir.exists()) {
+          throw new IOException("buffer dir:" + dir.getAbsolutePath()
+              + " is created unsuccessfully");
+        }
       }
     } else {
-      throw new IOException("creating buffer dir: " + dir.getAbsolutePath()
-          + "unsuccessfully.");
+      LOG.debug("buffer dir: {} already exists.", dirPath);
     }
 
     return dir;

hadoop-cloud-storage-project/hadoop-cos/src/main/java/org/apache/hadoop/fs/cosn/CosNInputStream.java

@@ -33,6 +33,8 @@
 import org.apache.hadoop.fs.FSInputStream;
 import org.apache.hadoop.fs.FileSystem;
 
+import javax.annotation.Nullable;
+
 /**
  * The input stream for the COS blob store.
  * Optimized sequential read flow based on a forward read-ahead queue
@@ -83,8 +85,15 @@ public void signalAll() {
       readyCondition.signalAll();
     }
 
+    @Nullable
     public byte[] getBuffer() {
-      return this.buffer;
+      if (this.buffer.length == 0) return null;
+
+      byte[] tempBuffer = new byte[this.buffer.length];
+      for (int index = 0; index < this.buffer.length; index++) {
+        tempBuffer[index] = this.buffer[index];
+      }
+      return tempBuffer;
     }
 
     public int getStatus() {

hadoop-cloud-storage-project/hadoop-cos/src/main/java/org/apache/hadoop/fs/cosn/CosNativeFileSystemStore.java

@@ -24,6 +24,7 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.net.URI;
+import java.nio.charset.Charset;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
@@ -68,6 +69,8 @@
 import org.apache.hadoop.util.VersionInfo;
 import org.apache.http.HttpStatus;
 
+import javax.annotation.Nullable;
+
 /**
  * The class actually performs access operation to the COS blob store.
  * It provides the bridging logic for the Hadoop's abstract filesystem and COS.
@@ -175,7 +178,7 @@ private void storeFileWithRetry(String key, InputStream inputStream,
       PutObjectResult putObjectResult =
           (PutObjectResult) callCOSClientWithRetry(putObjectRequest);
       LOG.debug("Store file successfully. COS key: [{}], ETag: [{}], "
-          + "MD5: [{}].", key, putObjectResult.getETag(), new String(md5Hash));
+          + "MD5: [{}].", key, putObjectResult.getETag(), Charset.defaultCharset());
     } catch (Exception e) {
       String errMsg = String.format("Store file failed. COS key: [%s], "
           + "exception: [%s]", key, e.toString());
@@ -197,7 +200,7 @@ public void storeFile(String key, File file, byte[] md5Hash)
       throws IOException {
     LOG.info("Store file from local path: [{}]. file length: [{}] COS key: " +
             "[{}] MD5: [{}].", file.getCanonicalPath(), file.length(), key,
-        new String(md5Hash));
+        Charset.defaultCharset());
     storeFileWithRetry(key, new BufferedInputStream(new FileInputStream(file)),
         md5Hash, file.length());
   }
@@ -247,10 +250,19 @@ public void storeEmptyFile(String key) throws IOException {
     }
   }
 
+  @Nullable
   public PartETag uploadPart(File file, String key, String uploadId,
       int partNum) throws IOException {
-    InputStream inputStream = new FileInputStream(file);
-    return uploadPart(inputStream, key, uploadId, partNum, file.length());
+    InputStream inputStream = null;
+    try {
+      inputStream = new FileInputStream(file);
+    }
+    finally {
+      if (inputStream != null) {
+        return uploadPart(inputStream, key, uploadId, partNum, file.length());
+      }
+    }
+    return null;
   }
 
   @Override