HADOOP-16637. Fix findbugs warnings in hadoop-cos. #1640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
| @@ -249,7 +250,15 @@ public void storeEmptyFile(String key) throws IOException { | |||
|
|
|||
| public PartETag uploadPart(File file, String key, String uploadId, | |||
| int partNum) throws IOException { | |||
| InputStream inputStream = new FileInputStream(file); | |||
| InputStream inputStream = null; | |||
There was a problem hiding this comment.
looks broken, as L262 will always get a closed stream
|
Most of the changes look good; that input stream cleanup looks like it will break the code as a closed stream will always get passed along to the next method. The findbugs file probably just needs changing. Which endpoint did you run the tests against? |
We just ran the findbugs for the file. |
|
ok. You need to run the full test suite against a live service and declare which location/endpoint you tested with that's the policy for all object store patches I'm afraid -Yetus can't be given the credentials and yet we need to stop regressions creeping in. Sorry |
|
Thanks @steveloughran for the comment. |
aajisaka
reviewed
Jan 7, 2020
| } else { | ||
| throw new IOException("creating buffer dir: " + dir.getAbsolutePath() | ||
| + "unsuccessfully."); | ||
| } |
There was a problem hiding this comment.
Thanks @aajisaka for the review.
Yes I would fix it, and run the test on this issue.
|
Hi @cxorm, how is this issue going? |
|
Thanks @aajisaka for the review. |
|
💔 -1 overall
This message was automatically generated. |
|
Hi @cxorm there is still 1 findbugs warning, would you check this? Sorry for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute