HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| } | ||
| .b td { | ||
| background: #fff; | ||
| } |
|
|
||
| } | ||
| h2 { | ||
| font-weight:bold; |
| } | ||
| h2 { | ||
| font-weight:bold; | ||
| font-size:140%; |
| h2 { | ||
| font-weight:bold; | ||
| font-size:140%; | ||
| margin-bottom: 5; |
|
💔 -1 overall
This message was automatically generated. |
adoroszlai
approved these changes
Sep 13, 2019
…ects for checkstyle validation.
nandakumar131
force-pushed
the
HDDS-2119
branch
from
197a32a to
fdc3c4d
Compare
hadoop-hdds/build-tools/src/main/resources/checkstyle/checkstyle-noframes-sorted.xsl
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
/retest |
|
Thanks @nandakumar131 the patch. Unfortunately it seems to be failing for me with testing it with the checkstyle.sh. Until now the checkstyle.sh did a I don't know what is the good solution here
I liked that it was very fast until know, therefore I would prefer the first one, but there could be other options... |
|
Thanks for the suggestion @elek . Modified |
|
Since we are not using maven artifact anymore, we don't need a new maven module |
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| <xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0"> |
|
💔 -1 overall
This message was automatically generated. |
|
Thanks @nandakumar131 the update. I would remove the build-tools for now. We can (re)create it when we can see the exact need. I think we can use |
|
Currently all the checkstyle checks are showing false negative answers. I will commit this with the suggested change (moving checkstyle XML files to the dev-support) if no objections... We can improve it (or switch back to the dedicated project) in follow-up jiras, but we need to fix the checks ASAP. |
|
Thanks @elek for taking care of this! |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…ects for checkstyle validation Closes apache#1435
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
…ects for checkstyle validation Closes apache#1435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1423 hdds/ozone no more relies on hadoop parent pom, so we have to use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation.