HDDS-2106. Avoid usage of hadoop projects as parent of hdds/ozone #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntributed by Elek, Marton.
adoroszlai
reviewed
Sep 11, 2019
There was a problem hiding this comment.
Thanks @elek for raising and addressing this issue.
Just a minor issue: version info is missing for two plugins. Can you please include these in pom.ozone.xml?
[WARNING] Some problems were encountered while building the effective model for org.apache.hadoop:hadoop-hdds-client:jar:0.5.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.rat:apache-rat-plugin is missing. @ org.apache.hadoop:hadoop-hdds:0.5.0-SNAPSHOT, /workdir/hadoop-hdds/pom.xml, line 284, column 15
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-enforcer-plugin is missing. @ org.apache.hadoop:hadoop-hdds:0.5.0-SNAPSHOT, /workdir/hadoop-hdds/pom.xml, line 268, column 15
|
Thanks @arp7 and @adoroszlai the review. There are no more warnings (missing parts are also migrated from pom.xml) and the integration test failures are not related. Will merge it soon. For the records: this is just the first step. As we have this brand new parent pom, later we can simplify the hadoop-ozone/pom.xml and hadoop-hdds/pom.xml as many common parts can be moved to pom.ozone.xml |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ozone uses hadoop as a dependency. The dependency defined on multiple level:
As we already have a slightly different assembly process it could be more resilient to use a dedicated parent project instead of the hadoop one. With this approach it will be easier to upgrade the versions as we don't need to be careful about the pom contents only about the used dependencies.
See: https://issues.apache.org/jira/browse/HDDS-2106