Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3062] fix(web): Support special character like "//" and improve the interceptors of axios #3118

Conversation

jerryshao
Copy link
Contributor

@jerryshao jerryshao commented Apr 23, 2024

What changes were proposed in this pull request?

  1. Support special character like '//' for database name or table name and so on.
image
  1. Improvment interceptors of axois for avoide repeat request
  2. Fix some runtime errors

Why are the changes needed?

N/A

Fix: #3062

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Manual

… interceptors of axios (#3116)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

1. Support special character like '//' for database name or table name
and so on.
<img width="852" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/9ae20ce1-3683-453a-a651-53a2277a8e25">

3. Improvment interceptors of axois for avoide repeat request
4. Fix some runtime errors

### Why are the changes needed?
N/A

Fix: #3062

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
Manual
@jerryshao jerryshao added cherry-pick need backport Issues that need to backport to another branch labels Apr 23, 2024
@yuqi1129 yuqi1129 merged commit a52e2ff into branch-0.5 Apr 23, 2024
22 checks passed
@yuqi1129 yuqi1129 deleted the cherry-pick-branch-0.5-f8b9458c196c3af155b02c685992d7dde8f7dc92 branch April 23, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants