Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Support special character like '//' for database name #3062

Closed
yuqi1129 opened this issue Apr 20, 2024 · 0 comments · Fixed by #3116
Closed

[Bug report] Support special character like '//' for database name #3062

yuqi1129 opened this issue Apr 20, 2024 · 0 comments · Fixed by #3116
Assignees
@LauraXia123 @mchades
Labels
bug Something isn't working
Milestone
Gravitino 0.5.0

Comments

@yuqi1129
Copy link
Contributor

Version

main branch

Describe what's wrong

image

Error message and/or stacktrace

please see above

How to reproduce

please see above

Additional context

No response
@yuqi1129 yuqi1129 added the bug Something isn't working label Apr 20, 2024
@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Apr 22, 2024
LauraXia123 added a commit to LauraXia123/gravitino that referenced this issue Apr 23, 2024
@LauraXia123
[apache#3062] Support special character like "//" and improvment inte…
a4171f8 
…rceptors of axois
@LauraXia123 LauraXia123 mentioned this issue Apr 23, 2024
Merged
@mchades mchades self-assigned this Apr 23, 2024
LauraXia123 added a commit that referenced this issue Apr 23, 2024
@LauraXia123
[#3062] fix(web): Support special character like "//" and improve the…
f8b9458 
… interceptors of axios (#3116)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

1. Support special character like '//' for database name or table name
and so on.
<img width="852" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/9ae20ce1-3683-453a-a651-53a2277a8e25">

3. Improvment interceptors of axois for avoide repeat request
4. Fix some runtime errors

### Why are the changes needed?
N/A

Fix: #3062

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
Manual
github-actions bot pushed a commit that referenced this issue Apr 23, 2024
@LauraXia123 @web-flow
[#3062] fix(web): Support special character like "//" and improve the…
e02b50b 
… interceptors of axios (#3116)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

1. Support special character like '//' for database name or table name
and so on.
<img width="852" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/9ae20ce1-3683-453a-a651-53a2277a8e25">

3. Improvment interceptors of axois for avoide repeat request
4. Fix some runtime errors

### Why are the changes needed?
N/A

Fix: #3062

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
Manual
@jerryshao jerryshao mentioned this issue Apr 23, 2024
Merged
yuqi1129 pushed a commit that referenced this issue Apr 23, 2024
@jerryshao @LauraXia123
[#3062] fix(web): Support special character like "//" and improve the…
a52e2ff 
… interceptors of axios (#3118)

### What changes were proposed in this pull request?

1. Support special character like '//' for database name or table name
and so on.
<img width="852" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/9ae20ce1-3683-453a-a651-53a2277a8e25">

3. Improvment interceptors of axois for avoide repeat request
4. Fix some runtime errors

### Why are the changes needed?
N/A

Fix: #3062

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
Manual

Co-authored-by: Qian Xia <lauraxiaqian@gmail.com>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@LauraXia123 @diqiu50
[apache#3062] fix(web): Support special character like "//" and impro…
596711f 
…ve the interceptors of axios (apache#3116)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

1. Support special character like '//' for database name or table name
and so on.
<img width="852" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/9ae20ce1-3683-453a-a651-53a2277a8e25">

3. Improvment interceptors of axois for avoide repeat request
4. Fix some runtime errors

### Why are the changes needed?
N/A

Fix: apache#3062

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
Manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LauraXia123 LauraXia123

@mchades mchades

Labels
bug Something isn't working
Projects
None yet
Milestone
Gravitino 0.5.0
4 participants
@jerryshao @LauraXia123 @yuqi1129 @mchades