[#241] test: build Hive2 docker runtime test environment #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
|
jerryshao
pushed a commit
that referenced
this pull request
Aug 22, 2023
### What changes were proposed in this pull request? Add some simple test for the repose classes. ### Why are the changes needed? To increase test coverage. Fix: #267 ### Does this PR introduce _any_ user-facing change? None ### How was this patch tested? Build and test passes. Co-authored-by: Justin Mclean <justin@datastrato.com>
support ARM and X86 architecture
|
@jerryshao Please help me review this PR, Thanks. |
jerryshao
reviewed
Aug 29, 2023
dev/docker/hive2/build-docker.sh
Outdated
| fi | ||
|
|
||
| # Option params --no-cache --push | ||
| docker buildx build --platform=linux/amd64,linux/arm64 --output type=docker --progress plain -t datastrato/hive2:0.1.1 . |
There was a problem hiding this comment.
Is this 0.1.1 a fixed number? Also, will this push the image to dockerhub?
There was a problem hiding this comment.
Yes, currently 0.1.1 is a fixed number, and this push to https://hub.docker.com/repository/docker/datastrato/hive2/tags?page=1&ordering=last_updated
|
|
This is the wrong uri, I updated the PR context with correct uri address. https://hub.docker.com/repository/docker/datastrato/hive2/tags?page=1&ordering=last_updated |
jerryshao
added
need backport
jerryshao
reviewed
Aug 29, 2023
jerryshao
approved these changes
Aug 29, 2023
jerryshao
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
### What changes were proposed in this pull request? Build a hive runtime environment docker image including: These versions match the Hadoop and Hive that Graviton depends on. 1. Hadoop-2.7.3 2. Hive-2.3.9 3. Mysql 4. openJDK-8u382 5. Support `linux/ARM64` and `linux/amd86` architecture ### Why are the changes needed? The hive catalog integration test need to connect really Hive runtime environment Fix: #241 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Success build and push to the docker hub + https://hub.docker.com/repository/docker/datastrato/hive2/tags?page=1&ordering=last_updated <img width="791" alt="image" src="https://github.com/datastrato/graviton/assets/3677382/7aee52b5-44f4-4f7c-ae4a-8703c7daca94">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Build a hive runtime environment docker image including:
These versions match the Hadoop and Hive that Graviton depends on.
linux/ARM64andlinux/amd86architectureWhy are the changes needed?
The hive catalog integration test need to connect really Hive runtime environment
Fix: #241
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Success build and push to the docker hub