[#2041][#2306] Improvement(catalog-hadoop):Add E2E integration test for Hadoop catalog #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolderli
force-pushed
the
issue-2041
branch
from
50ba9a4
to
39ad1d7
Compare
coolderli
changed the title
coolderli
changed the title
coolderli
changed the title
|
@jerryshao @yuqi1129 @qqqttt123 @mchades Could you help me review this? Thanks. |
jerryshao
reviewed
Feb 22, 2024
| @@ -575,7 +578,7 @@ private FilesetEntity updateFilesetEntity( | |||
| .withName(newName) | |||
| .withNamespace(ident.namespace()) | |||
| .withId(filesetEntity.id()) | |||
| .withComment(filesetEntity.comment()) | |||
| .withComment(newComment) | |||
There was a problem hiding this comment.
Can you add a UT to cover this?
| break; | ||
| case TABLE: | ||
| case FILESET: |
There was a problem hiding this comment.
Also here, I think it is necessary to have UTs to cover it.
There was a problem hiding this comment.
@yuqi1129 can you please help to review this part and the UT added below?
There was a problem hiding this comment.
@jerryshao
He has added test cases about it, please see validateDeleteSchemaCascade, validateDeleteCatalogCascade, and validateDeleteFilesetCascade
There was a problem hiding this comment.
The other parts are fine for me.
coolderli
force-pushed
the
issue-2041
branch
from
336c3aa
to
b0f1d60
Compare
|
@jerryshao Could you take a look, I refactor some UTs. Thanks. |
jerryshao
changed the title
jerryshao
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #2041
Fix: #2306
Does this PR introduce any user-facing change?
How was this patch tested?
./gradlew build