Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add more unit tests for fileset #2306

Closed
coolderli opened this issue Feb 22, 2024 · 3 comments · Fixed by #2294
Closed

[Improvement] Add more unit tests for fileset #2306

coolderli opened this issue Feb 22, 2024 · 3 comments · Fixed by #2294
Labels
improvement Improvements on everything

Comments

@coolderli
Copy link
Collaborator

coolderli commented Feb 22, 2024 •
edited
Loading

What would you like to be improved?

There are some missing UT for fileset on :

  • TestEntityStore
  • TestKvEntityStorage
  • TestKvEntityStorage

In this issue, I will add them.

How should we improve?

add more UTs

Parent issue

#1241
@coolderli coolderli added the improvement Improvements on everything label Feb 22, 2024
@coolderli
Copy link
Collaborator Author

@jerryshao @yuqi1129 @qqqttt123
What do you think about this? Are there any other UTs that need to be added？

@justinmclean
Copy link
Member

The Audit info related functions does't seem to have much coverage.

@jerryshao
Copy link
Contributor

I saw there are some fixes in your E2E test about fileset support in kv storage, I think it is valuable to add more UTs.

@coolderli coolderli mentioned this issue Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
3 participants
@justinmclean @jerryshao @coolderli