[#12221] feat(iceberg): Add durable table delete lifecycle - #12225
Draft
nevzheng wants to merge 5 commits into
Draft
[#12221] feat(iceberg): Add durable table delete lifecycle#12225nevzheng wants to merge 5 commits into
nevzheng wants to merge 5 commits into
Conversation
This was referenced Jul 27, 2026
nevzheng
force-pushed
the
codex/iceberg-rest-delete-20-01-delete-lifecycle
branch
2 times, most recently
from
July 28, 2026 01:01
2c226a1 to
634f7eb
Compare
Code Coverage Report
Files |
nevzheng
force-pushed
the
codex/iceberg-rest-delete-20-01-delete-lifecycle
branch
from
July 28, 2026 03:09
634f7eb to
55fdd1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is Stack 20.1 of 3 and depends on #12223.
table_metarow by immutabletable_idwithSELECT ... FOR UPDATE;deletion_id,state,retention_expires_at,purge_job_id); anddeleted_atand the samedeletion_idon the locked row using its current schema, name, and metadata version.table_id; the action does not duplicate them.This layer intentionally does not add terminal restore receipts, copied identity fields, action revisions, or a deletion-audit table. Existing entity change events remain the cache-propagation mechanism.
Review order: #12222 → #12223 → this PR → #12226 → #12227.
Incremental diff:
nevzheng/gravitino@codex/iceberg-rest-delete-10-02-action-storage...codex/iceberg-rest-delete-20-01-delete-lifecycle
Why are the changes needed?
This establishes the durable logical-delete boundary used by deleted-table reads, UNDROP, and a later asynchronous purge implementation without introducing a request-thread saga.
Related: #12221
Does this PR introduce any user-facing change?
Yes. When Iceberg REST soft deletion is enabled, DELETE retains and hides the existing table row and reserves its name. When it is disabled, existing behavior is unchanged.
How was this patch tested?
Added cross-backend relational lifecycle tests plus configuration, authorization, REST DELETE, dispatcher, name-reservation, retry, locked-current-version, and outer-transaction rollback tests. The focused Core and Iceberg REST Server suites pass.