[#12220] feat(core): Add active deletion schema and models - #12222
Open
nevzheng wants to merge 1 commit into
Open
[#12220] feat(core): Add active deletion schema and models#12222nevzheng wants to merge 1 commit into
nevzheng wants to merge 1 commit into
Conversation
This was referenced Jul 27, 2026
nevzheng
force-pushed
the
codex/iceberg-rest-delete-10-01-schema-models
branch
from
July 27, 2026 23:19
a7e0ffa to
c50ede2
Compare
nevzheng
marked this pull request as ready for review
July 27, 2026 23:19
This was referenced Jul 28, 2026
Code Coverage Report
Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is PR 1 of 2 in the deletion-generation storage stack.
table_meta.deletion_idpointer for one active table-deletion generation.entity_deletiontable containingdeletion_id, lifecyclestate, the fixedretention_expires_atdeadline, and an optionalpurge_job_id.This PR deliberately does not add deletion identifiers to table-owned child rows, duplicate table identity in the action, retain terminal receipts, or introduce deletion-specific audit storage.
Stack:
After this PR, relational storage can represent a retained table root and its minimal active deletion action. It does not yet change DELETE, UNDROP, or purge runtime behavior.
Why are the changes needed?
Soft deletion needs an opaque identifier for each active deletion generation and a fixed recovery deadline. The original
table_metarow remains the source of table identity, name, parent, and deletion time, whileentity_deletionstores only the short-lived lifecycle and future purge-job association.Keeping the action minimal avoids duplicating metadata that already belongs to the retained table root and lets a later transaction layer remove the action after either successful restoration or final purge.
Part of #12220
Does this PR introduce any user-facing change?
No. This PR adds relational schema and persistent-object support only. It does not change public APIs or runtime deletion behavior.
How was this patch tested?