Skip to content

Conversation

@Taack
Copy link

@Taack Taack commented Oct 21, 2025

fix bug #15129, without this patch, messages are not loaded.

Regards

@github-actions github-actions bot added the bug label Oct 21, 2025
Copy link
Contributor

@sbglasius sbglasius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you can add a test-case for StaticResourceLoader that would be awesome.

@Taack
Copy link
Author

Taack commented Oct 21, 2025

You have to install our infra on local maven, as stated in bug report #15128...

Here is the test case:

intranet.tar.gz

export JAVA_HOME=...Java 24
cd intranet
./gradlew server:bootRun

As in bug report #15128, Login = admin, passwd = ChangeIt

Regards

@Taack
Copy link
Author

Taack commented Oct 21, 2025

Looks good. If you can add a test-case for StaticResourceLoader that would be awesome

I will try to provide a unit test-case. Regards.

@Taack Taack requested a review from sbglasius October 21, 2025 12:45
@jamesfredley jamesfredley moved this to In Progress in Apache Grails Oct 21, 2025
@jamesfredley jamesfredley added this to the grails:7.0.1 milestone Oct 21, 2025
@Taack
Copy link
Author

Taack commented Oct 21, 2025

How to pass the CodeQL check "Uncontrolled data used in path expression" ?

Do I need to check location variable (it is empty in my use-case) ? Is it blocking the merge ?

Regards

@jdaugherty
Copy link
Contributor

I'm investigating this but this change will likely not be for 7.0.1. I'd rather see us make use of the exploded feature and ensure this issue still exists. I'm hoping I have time today, if not it will have to wait until next week (after the 7.0.1 merge window).

@Taack
Copy link
Author

Taack commented Oct 24, 2025

Great !

I updated the bug report with a simpler test-case. TGIF!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

hotreload & multi-project: doFindPathMatchingFileResources looks after resources into the wrong path

4 participants