Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify service annotation protocol #5051

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dubbo.config.spring.beans.factory.annotation;

import org.apache.dubbo.config.ProtocolConfig;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
import org.springframework.beans.factory.support.BeanDefinitionRegistry;
import org.springframework.beans.factory.support.BeanDefinitionRegistryPostProcessor;
import org.springframework.beans.factory.support.DefaultListableBeanFactory;

public class ProtocolAnnotationBeanPostProcessor implements BeanDefinitionRegistryPostProcessor {

public static final String BEAN_NAME = "protocolAnnotationBeanPostProcessor";

@Override
public void postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry) throws BeansException {
if (registry instanceof DefaultListableBeanFactory) {
DefaultListableBeanFactory factory = (DefaultListableBeanFactory) registry;
String[] beanNames = factory.getBeanNamesForType(ProtocolConfig.class, true, false);
for (String beanName : beanNames) {
ProtocolConfig config = (ProtocolConfig) factory.getBean(beanName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getBean method will cause the initialization of ProtocolConfig's bean too early

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getBean method will cause the initialization of ProtocolConfig's bean too early

I have created a PR #5063.. to avoid the eager initialization of ProtocolConfig's bean

if (!factory.hasAlias(beanName, config.getId())) {
registry.registerAlias(beanName, config.getId());
}
}
}
}

@Override
public void postProcessBeanFactory(ConfigurableListableBeanFactory configurableListableBeanFactory) throws BeansException {

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package org.apache.dubbo.config.spring.context.annotation;

import org.apache.dubbo.config.annotation.Service;
import org.apache.dubbo.config.spring.beans.factory.annotation.ProtocolAnnotationBeanPostProcessor;
import org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor;
import org.apache.dubbo.config.spring.beans.factory.annotation.ServiceAnnotationBeanPostProcessor;
import org.apache.dubbo.config.spring.util.BeanRegistrar;
Expand Down Expand Up @@ -60,6 +61,7 @@ public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, B

registerReferenceAnnotationBeanPostProcessor(registry);

registerProtocolAnnotationBeanPostProcessor(registry);
}

/**
Expand Down Expand Up @@ -92,6 +94,10 @@ private void registerReferenceAnnotationBeanPostProcessor(BeanDefinitionRegistry

}

private void registerProtocolAnnotationBeanPostProcessor(BeanDefinitionRegistry registry) {
BeanRegistrar.registerInfrastructureBean(registry, ProtocolAnnotationBeanPostProcessor.BEAN_NAME, ProtocolAnnotationBeanPostProcessor.class);
}

private Set<String> getPackagesToScan(AnnotationMetadata metadata) {
AnnotationAttributes attributes = AnnotationAttributes.fromMap(
metadata.getAnnotationAttributes(DubboComponentScan.class.getName()));
Expand Down