Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify service annotation protocol #5051

Closed
wants to merge 1 commit into from
Closed

specify service annotation protocol #5051

wants to merge 1 commit into from

Conversation

haiyang1985
Copy link
Member

@haiyang1985 haiyang1985 commented Sep 11, 2019

What is the purpose of the change

For Issue #5049

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Contributor

@mercyblitz mercyblitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could create a bean of DubboConfigBeanCustomizer to add the alias that you want

DefaultListableBeanFactory factory = (DefaultListableBeanFactory) registry;
String[] beanNames = factory.getBeanNamesForType(ProtocolConfig.class, true, false);
for (String beanName : beanNames) {
ProtocolConfig config = (ProtocolConfig) factory.getBean(beanName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getBean method will cause the initialization of ProtocolConfig's bean too early

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getBean method will cause the initialization of ProtocolConfig's bean too early

I have created a PR #5063.. to avoid the eager initialization of ProtocolConfig's bean

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


vghy顾海洋 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants