Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dubbo] Fix StringIndexOutOfBoundsException when len=0 #4402 #4425

Merged
merged 2 commits into from
Jul 17, 2019
Merged

[Dubbo] Fix StringIndexOutOfBoundsException when len=0 #4402 #4425

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec3ff41
add guard clause for len=0
Jun 29, 2019
18bc2de
add guard clause for len=0
sunbufu Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dubbo-common/src/main/java/org/apache/dubbo/common/io/Bytes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,9 @@ public static byte[] base642bytes(final String str, final int off, final int len
if (len < 0) {
throw new IndexOutOfBoundsException("base642bytes: length < 0, length is " + len);
}
if (len == 0) {
sunbufu marked this conversation as resolved.
Show resolved Hide resolved
return new byte[0];
}
if (off + len > str.length()) {
throw new IndexOutOfBoundsException("base642bytes: offset + length > string length.");
}
Expand Down
3 changes: 3 additions & 0 deletions dubbo-common/src/test/java/org/apache/dubbo/common/io/BytesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ public void testMain() throws Exception {

byte[] bytesWithC64 = Bytes.base642bytes(str, C64);
assertThat(bytesWithC64, is(bytes));

byte[] emptyBytes = Bytes.base642bytes("dubbo", 0, 0);
assertThat(emptyBytes, is("".getBytes()));
}

@Test
Expand Down