Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo] Fix StringIndexOutOfBoundsException when len=0 #4402 #4425

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

sunbufu
Copy link
Contributor

@sunbufu sunbufu commented Jun 29, 2019

What is the purpose of the change

fix #4402

Brief changelog

add guard clause for len=0 in method base642bytes

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Jul 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (2.7.3-release@9b7c697). Click here to learn what that means.
The diff coverage is 75%.

Impacted file tree graph

@@               Coverage Diff                @@
##             2.7.3-release    #4425   +/-   ##
================================================
  Coverage                 ?   63.05%           
  Complexity               ?      452           
================================================
  Files                    ?      788           
  Lines                    ?    34682           
  Branches                 ?     5418           
================================================
  Hits                     ?    21870           
  Misses                   ?    10297           
  Partials                 ?     2515
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/org/apache/dubbo/common/io/Bytes.java 68% <75%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b7c697...18bc2de. Read the comment docs.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunbufu pls. check my review comments.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, will merge once CI passes.

@beiwei30 beiwei30 merged commit 2e341d1 into apache:2.7.3-release Jul 17, 2019
chickenlj pushed a commit that referenced this pull request Jul 19, 2019
* add guard clause for len=0

* add guard clause for len=0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants