Fixing test-order dependency for FstObjectInputTest #2815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When tests in FstObjectOutputTest, e.g., testWriteInt, runs right before FstObjectInputTest, FstObjectInputTest fails. There is some state from FstObjectInput that is preserved between the test runs that leads to FstObjectInputTest to fail when run afterwards.
The proposed fix is a patch that I found can help reset the state so FstObjectInputTest does not fail when run afterwards. The patch is based off of FstObjectOutputTest.testWriteBool, which indirectly resets the state itself. As such, another potential patch is to use the entire testWriteBool logic in the tearDown method:
I would be happy to discuss other ways of fixing the issue.
Brief changelog
dubbo-serialization/dubbo-serialization-test/src/test/java/org/apache/dubbo/common/serialize/fst/FstObjectOutputTest.java
Verifying this change
fails before the change. The same command will pass after the change.