[Dubbo-2864] Fix build failed with -Prelease

[biyuhao]

fixes #2864

What is the purpose of the change

fix build failure

Brief changelog

update dubbo-common/pom.xml

Verifying this change

build with release profile
./mvnw package -DskipTests -Pjava8-vm-args -Prelease

Follow this checklist to help us incorporate your contribution quickly and easily:

• Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
• Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
• If this contribution is large, please follow the Software Donation Guide.

[codecov-io]

Codecov Report

Merging #2923 into master will decrease coverage by 1.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2923      +/-   ##
==========================================
- Coverage   63.82%   62.61%   -1.22%     
==========================================
  Files         578      600      +22     
  Lines       25954    27943    +1989     
  Branches     4543     4831     +288     
==========================================
+ Hits        16565    17496     +931     
- Misses       7220     8167     +947     
- Partials     2169     2280     +111

Impacted Files	Coverage Δ
.../remoting/transport/netty4/NettyClientHandler.java	75% <0%> (-13.89%)	⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java	41.66% <0%> (-8.34%)	⬇️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java	54.21% <0%> (-3.62%)	⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java	58.88% <0%> (-1.75%)	⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java	68.45% <0%> (-1.35%)	⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java	63.04% <0%> (ø)	⬆️
...bbo/rpc/protocol/thrift/io/InputStreamWrapper.java	0% <0%> (ø)
...o/rpc/protocol/thrift/DubboClassNameGenerator.java	100% <0%> (ø)
.../java/org/apache/dubbo/common/json/JSONWriter.java	63.15% <0%> (ø)
...a/org/apache/dubbo/common/json/ParseException.java	0% <0%> (ø)
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e508ad4...322fb6a. Read the comment docs.

[beiwei30]

pls. hold on, I don't think we can do this.

[beiwei30]

I think we should keep scope as 'provided' since we don't want to package log4j2 into dubbo distribution. Therefore, we should workaround it by modifying the following config in the root pom.xml:

        <profile>
            <id>release</id>
            <properties>
                <log4j2_version>2.11.1</log4j2_version>
            </properties>
            <build>
                <plugins>
                    <plugin>
                        <artifactId>maven-javadoc-plugin</artifactId>
                        <version>${maven_javadoc_version}</version>
                        <executions>
                            <execution>
                                <id>attach-javadoc</id>
                                <goals>
                                    <goal>jar</goal>
                                </goals>
                                <configuration>
                                    <doclint>none</doclint>
                                    <additionalDependencies>
                                        <additionalDependency>
                                            <groupId>org.apache.logging.log4j</groupId>
                                            <artifactId>log4j-api</artifactId>
                                            <version>${log4j2_version}</version>
                                        </additionalDependency>
                                        <additionalDependency>
                                            <groupId>org.apache.logging.log4j</groupId>
                                            <artifactId>log4j-core</artifactId>
                                            <version>${log4j2_version}</version>
                                        </additionalDependency>
                                    </additionalDependencies>
                                </configuration>
                            </execution>
                        </executions>
                        <configuration>
                            <show>public</show>
                            <charset>UTF-8</charset>
                            <encoding>UTF-8</encoding>
                            <docencoding>UTF-8</docencoding>
                            <links>
                                <link>http://docs.oracle.com/javase/7/docs/api</link>
                            </links>
                        </configuration>
                    </plugin>
                    <plugin>
                        <groupId>org.apache.maven.plugins</groupId>
                        <artifactId>maven-gpg-plugin</artifactId>
                        <executions>
                            <execution>
                                <phase>verify</phase>
                                <goals>
                                    <goal>sign</goal>
                                </goals>
                            </execution>
                        </executions>
                    </plugin>
                </plugins>
            </build>
        </profile>

what do you think?

[biyuhao]

@beiwei30 modified as per your suggestion, it is surely the better solution. Thanks!