Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue-303]add the tag corethreads to the complex tag <dubbo:protocol> in dubbo.xsd #1989

Merged
merged 9 commits into from
Jul 18, 2018
Merged

[issue-303]add the tag corethreads to the complex tag <dubbo:protocol> in dubbo.xsd #1989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6b0bd1a
parameter是一个注解对象，此处调用它的key方法没有实际用处，所以删除这一行代码
tswstarplanet May 28, 2018
cd8e97d
Merge branch 'pr/1'
tswstarplanet Jun 26, 2018
20644bc
fix the potential null pointer exception
tswstarplanet Jun 26, 2018
06a0ca4
Merge pull request #2 from apache/master
tswstarplanet Jul 6, 2018
a4793ba
Merge pull request #3 from apache/master
tswstarplanet Jul 12, 2018
a0bc50d
Merge pull request #4 from apache/master
tswstarplanet Jul 17, 2018
a93a5db
Add the corethreads tag to the complex tab <dubbo:protocol>
tswstarplanet Jul 17, 2018
e8e2a2d
删除不确定是否有问题的issue的提交代码
tswstarplanet Jul 17, 2018
31a9164
delete the unnecessary import
tswstarplanet Jul 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ProtocolConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ public class ProtocolConfig extends AbstractConfig {
// thread pool
private String threadpool;

// thread pool core thread size
private Integer corethreads;

// thread pool size (fixed size)
private Integer threads;

Expand Down Expand Up @@ -207,6 +210,14 @@ public void setThreadpool(String threadpool) {
this.threadpool = threadpool;
}

public Integer getCorethreads() {
return corethreads;
}

public void setCorethreads(Integer corethreads) {
this.corethreads = corethreads;
}

public Integer getThreads() {
return threads;
}
Expand Down
7 changes: 7 additions & 0 deletions dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/ProtocolConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,13 @@ public void testPath() throws Exception {
assertThat(protocol.getContextpath(), equalTo("path"));
}

@Test
public void testCorethreads() throws Exception {
ProtocolConfig protocol = new ProtocolConfig();
protocol.setCorethreads(10);
assertThat(protocol.getCorethreads(), is(10));
}

@Test
public void testThreads() throws Exception {
ProtocolConfig protocol = new ProtocolConfig();
Expand Down
5 changes: 5 additions & 0 deletions dubbo-config/dubbo-config-spring/src/main/resources/META-INF/dubbo.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,6 +789,11 @@
<xsd:documentation><![CDATA[ The thread pool size. ]]></xsd:documentation>
</xsd:annotation>
</xsd:attribute>
<xsd:attribute name="corethreads" type="xsd:string" use="optional">
<xsd:annotation>
<xsd:documentation><![CDATA[ The thread pool core threads size. ]]></xsd:documentation>
</xsd:annotation>
</xsd:attribute>
<xsd:attribute name="iothreads" type="xsd:string" use="optional">
<xsd:annotation>
<xsd:documentation><![CDATA[ The IO thread pool size. ]]></xsd:documentation>
Expand Down