Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue-303]add the tag corethreads to the complex tag <dubbo:protocol> in dubbo.xsd #1989

Merged
merged 9 commits into from
Jul 18, 2018
Merged

[issue-303]add the tag corethreads to the complex tag <dubbo:protocol> in dubbo.xsd #1989

merged 9 commits into from
Jul 18, 2018

Conversation

tswstarplanet
Copy link
Contributor

@tswstarplanet tswstarplanet commented Jun 26, 2018 •
edited
Loading

What is the purpose of the change

Add the missing tag corethreads to the complex tag dubbo:protocol in dubbo.xsd and relative code, with the unit test case

@tswstarplanet tswstarplanet changed the title fix the potential null pointer exception in class StaticDirectory [#1988]fix the potential null pointer exception in class StaticDirectory Jun 26, 2018
@codecov-io
Copy link

codecov-io commented Jun 26, 2018 •
edited
Loading

Codecov Report

Merging #1989 into master will increase coverage by 1.23%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1989      +/-   ##
============================================
+ Coverage     53.05%   54.28%   +1.23%     
- Complexity     4957     5077     +120     
============================================
  Files           559      559              
  Lines         24894    25200     +306     
  Branches       4432     4579     +147     
============================================
+ Hits          13207    13681     +474     
+ Misses         9667     9494     -173     
- Partials       2020     2025       +5
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/config/ProtocolConfig.java 74.07% <100%> (+0.58%) 61 <2> (+2) ⬆️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 37.5% <0%> (-4.17%) 3% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65% <0%> (-1.25%) 22% <0%> (-1%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 55.69% <0%> (+1.26%) 13% <0%> (+1%) ⬆️
...apache/dubbo/common/extension/ExtensionLoader.java 78.24% <0%> (+5.59%) 131% <0%> (+15%) ⬆️
...e/dubbo/common/beanutil/JavaBeanSerializeUtil.java 79.38% <0%> (+6.52%) 86% <0%> (+18%) ⬆️
...onfig/spring/extension/SpringExtensionFactory.java 85.71% <0%> (+7.14%) 10% <0%> (ø) ⬇️
...java/org/apache/dubbo/common/bytecode/Wrapper.java 75.93% <0%> (+8.02%) 38% <0%> (+4%) ⬆️
...g/apache/dubbo/common/bytecode/ClassGenerator.java 68.03% <0%> (+13.6%) 64% <0%> (+21%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc56f48...31a9164. Read the comment docs.

@tswstarplanet tswstarplanet changed the title [#1988]fix the potential null pointer exception in class StaticDirectory [Dubbo-1988]fix the potential null pointer exception in class StaticDirectory Jun 26, 2018
@imsunv
Copy link
Contributor

imsunv commented Jun 29, 2018 •
edited by ralf0131
Loading

#303

@chickenlj chickenlj added this to the 2.6.3 milestone Jul 9, 2018
@tswstarplanet tswstarplanet changed the title [Dubbo-1988]fix the potential null pointer exception in class StaticDirectory [Dubbo-1988]&[Dubbo-303] Jul 17, 2018
@tswstarplanet tswstarplanet changed the title [Dubbo-1988]&[Dubbo-303] [Dubbo-1988]fix the potential null pointer exception in class StaticDirectory Jul 17, 2018
@tswstarplanet tswstarplanet changed the title [Dubbo-1988]fix the potential null pointer exception in class StaticDirectory [Dubbo-1988]fix the potential null pointer exception in class StaticDirectory [Dubbo-303]add the tag corethreads to the complex tag <dubbo:protocol> in dubbo.xsd Jul 17, 2018
@tswstarplanet tswstarplanet mentioned this pull request Jul 17, 2018
Closed
@tswstarplanet tswstarplanet changed the title [Dubbo-1988]fix the potential null pointer exception in class StaticDirectory [Dubbo-303]add the tag corethreads to the complex tag <dubbo:protocol> in dubbo.xsd [issue-303]add the tag corethreads to the complex tag <dubbo:protocol> in dubbo.xsd Jul 17, 2018
@ralf0131
Copy link
Contributor

@whanice This pr should be related to #303

@ralf0131
Copy link
Contributor

Looks good to me! Thanks for the pull request.

@ralf0131 ralf0131 merged commit 588214b into apache:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@tswstarplanet @codecov-io @imsunv @ralf0131 @chickenlj