Skip to content

End the 'read/write' combination operation early to improve performance #15666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EarthChen merged 2 commits into from
Sep 24, 2025
Merged

End the 'read/write' combination operation early to improve performance #15666

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ff86ca
End the 'read/write' combination operation early to improve performance
frozenNoob Sep 2, 2025
2619195
Merge branch '3.3' into 3.3
zrlw Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ter/src/main/java/org/apache/dubbo/rpc/cluster/loadbalance/ConsistentHashLoadBalance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ protected <T> Invoker<T> doSelect(List<Invoker<T>> invokers, URL url, Invocation
String methodName = RpcUtils.getMethodName(invocation);
String key = invokers.get(0).getUrl().getServiceKey() + "." + methodName;
int invokersHashCode = invokers.hashCode();
// If the detection is successful, return in advance. it may be different from selector, but it doesn't matter
ConsistentHashSelector<T> oldSelector0;
if ((oldSelector0 = (ConsistentHashSelector<T>) selectors.get(key)) != null
&& oldSelector0.identityHashCode == invokersHashCode) {
return oldSelector0.select(invocation);
}

// using the hashcode of invoker list to create consistent selector by atomic computation.
ConsistentHashSelector<T> selector = (ConsistentHashSelector<T>) selectors.compute(
key,
Expand Down
Loading