End the 'read/write' combination operation early to improve performance#15666
Merged
EarthChen merged 2 commits intoapache:3.3from Sep 24, 2025
Merged
End the 'read/write' combination operation early to improve performance#15666EarthChen merged 2 commits intoapache:3.3from
EarthChen merged 2 commits intoapache:3.3from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15666 +/- ##
============================================
- Coverage 61.02% 61.01% -0.02%
- Complexity 11702 11708 +6
============================================
Files 1923 1923
Lines 87074 87077 +3
Branches 13112 13114 +2
============================================
- Hits 53134 53127 -7
- Misses 28490 28500 +10
Partials 5450 5450
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zrlw
approved these changes
Sep 18, 2025
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Fix the issue:In multi-threaded parallel execution, a large number of read only operations waste a lot of unnecessary time because the combination of
read and writeoperations requiresserializationissue link: #15665
My Solution
Issue 1 must be solved, Issue 2 can be tolerated.
My proposed solution is as follows: allow a large number of read-only operations to proceed in parallel (memory visibility is guaranteed because the
valuefield in the inner classNodeofConcurrentHashMapisvolatile), and terminate early via detection.Related code is as follows:
Checklist