-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: client supports requests to server-streaming endpoints without parameters #15029
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15029 +/- ##
============================================
+ Coverage 60.73% 60.75% +0.01%
- Complexity 10860 10866 +6
============================================
Files 1882 1882
Lines 85997 86004 +7
Branches 12881 12884 +3
============================================
+ Hits 52233 52250 +17
+ Misses 28315 28306 -9
+ Partials 5449 5448 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@EarthChen PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change?
#15026 支持了无参的外部调用的情况下,而直接使用dubboconsumer时,由于定死了参数数量为2,导致请求时会报错,故对consumer侧的实现进行了兼容处理
using DubboConsumer directly causes an error during the request because the number of parameters is fixed to 2. Therefore, compatibility handling has been implemented on the consumer side.
Checklist