Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: server stream supports requests without parameters #15026

Merged
merged 11 commits into from
Dec 31, 2024

Conversation

funky-eyes
Copy link
Contributor

What is the purpose of the change?

image
在http1.1上服务端做推送时可能不需要参数,而是通过url来区分业务,比如一些广播频道
In HTTP/1.1, when the server performs push, it may not require parameters but rather differentiate the business logic through the URL, such as with broadcast channels.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 60.78%. Comparing base (0fd3706) to head (6bbc1a6).

Files with missing lines Patch % Lines
...he/dubbo/rpc/model/ReflectionMethodDescriptor.java 72.22% 3 Missing and 2 partials ⚠️
...otocol/tri/h12/ServerStreamServerCallListener.java 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15026      +/-   ##
============================================
+ Coverage     60.76%   60.78%   +0.01%     
+ Complexity    10867    10865       -2     
============================================
  Files          1882     1882              
  Lines         85990    85997       +7     
  Branches      12878    12881       +3     
============================================
+ Hits          52251    52271      +20     
+ Misses        28297    28286      -11     
+ Partials       5442     5440       -2     
Flag Coverage Δ
integration-tests 32.99% <12.00%> (-0.15%) ⬇️
samples-tests 29.20% <40.00%> (-0.03%) ⬇️
unit-tests 58.94% <64.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@funky-eyes funky-eyes closed this Dec 30, 2024
@funky-eyes funky-eyes reopened this Dec 30, 2024
Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 1da23ea into apache:3.3 Dec 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants