Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exporter append #722

Merged
merged 10 commits into from
Sep 5, 2020
Merged

fix exporter append #722

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cadae7b
format
Aug 19, 2020
941e69d
format
Aug 20, 2020
1708b41
fix bug
Aug 20, 2020
60f9822
format
Aug 20, 2020
96d0f79
format
Aug 27, 2020
09fa354
format
Aug 28, 2020
f8434c3
format
Sep 1, 2020
6707cdc
Merge branch 'develop' into read
Sep 1, 2020
c1e9b84
format
Sep 1, 2020
763b436
fix bug
Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format
  • Loading branch information
xg.gao committed Sep 1, 2020
commit f8434c317b7a175a395e3e9b470893898ad4ffcc
5 changes: 3 additions & 2 deletions registry/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ import (
type Registry interface {
common.Node

// used for service provider calling, register services to registry
// And it is also used for service consumer calling, register
// Register is used for service provider calling, register services
// to registry. And it is also used for service consumer calling, register
// services cared about, for dubbo's admin monitoring.
Register(url common.URL) error

Expand All @@ -45,6 +45,7 @@ type Registry interface {
// dubbo://10.20.153.10/org.apache.dubbo.foo.BarService?version=1.0.0&application=kylin
UnRegister(url common.URL) error

// Subscribe is required to support the contract:
// When creating new registry extension, pls select one of the
zouyx marked this conversation as resolved.
Show resolved Hide resolved
// following modes.
// Will remove in dubbogo version v1.1.0
Expand Down