fix exporter append #722
Merged
fix exporter append #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
requested review from
zouyx and
hxmhlt
and removed request for
zouyx
AlexStocks
approved these changes
Aug 21, 2020
added 2 commits
August 27, 2020 12:57
zouyx
reviewed
Aug 30, 2020
zouyx
approved these changes
Sep 3, 2020
zouyx
added a commit
to zouyx/dubbo-go
that referenced
this pull request
Sep 22, 2020
fix exporter append
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
在
if len(regUrls) > 0的分支里面，对regUrls进行循环，其中每个regUrl生成的exporter都应该放到append到exporters里面。但是现在的代码里面只有最后一个append到exporters里面了。所以应该在代码的
216行下面加一个c.exporters = append(c.exporters, exporter)。