Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:merge #2559 into main branch #2568

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

FinalT
Copy link
Member

@FinalT FinalT commented Jan 7, 2024

refer #2566

@FinalT FinalT changed the title merge #2559 into main branch fix:merge #2559 into main branch Jan 7, 2024
Copy link

sonarcloud bot commented Jan 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.8% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7341d50) 47.74% compared to head (ced89c1) 47.78%.

❗ Current head ced89c1 differs from pull request most recent head ad64b82. Consider uploading reports for the commit ad64b82 to get more accurate results

Files Patch % Lines
cluster/router/condition/dynamic_router.go 20.00% 3 Missing and 1 partial ⚠️
cluster/router/tag/router.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2568      +/-   ##
==========================================
+ Coverage   47.74%   47.78%   +0.03%     
==========================================
  Files         318      318              
  Lines       23420    23420              
==========================================
+ Hits        11183    11192       +9     
+ Misses      11179    11169      -10     
- Partials     1058     1059       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chickenlj chickenlj merged commit 4f21a41 into apache:main Jan 8, 2024
5 checks passed
@FinalT FinalT deleted the fix-router-logger branch January 8, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants