-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.1] Fix:modify router warn log #2559
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-3.1 #2559 +/- ##
===============================================
- Coverage 44.86% 44.82% -0.05%
===============================================
Files 270 270
Lines 18366 18366
===============================================
- Hits 8240 8232 -8
- Misses 9240 9247 +7
- Partials 886 887 +1 ☔ View full report in Codecov by Sentry. |
I see more warn log, can you fix it all
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
related #2558
I think if users don't set config center ,we should print a info log rather than a warning, telling the user that the router will not be enabled