Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] Fix:modify router warn log #2559

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

FinalT
Copy link
Member

@FinalT FinalT commented Jan 4, 2024

related #2558
I think if users don't set config center ,we should print a info log rather than a warning, telling the user that the router will not be enabled

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a4d9d0a) 44.86% compared to head (a803b20) 44.82%.

❗ Current head a803b20 differs from pull request most recent head 41b3ea5. Consider uploading reports for the commit 41b3ea5 to get more accurate results

Files Patch % Lines
cluster/router/condition/dynamic_router.go 0.00% 2 Missing ⚠️
cluster/router/tag/router.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-3.1    #2559      +/-   ##
===============================================
- Coverage        44.86%   44.82%   -0.05%     
===============================================
  Files              270      270              
  Lines            18366    18366              
===============================================
- Hits              8240     8232       -8     
- Misses            9240     9247       +7     
- Partials           886      887       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FoghostCn
Copy link
Contributor

I see more warn log, can you fix it all

WARN    tag/router.go:87        config center does not start, please check if the configuration center has been properly configured in dubbogo.yml
WARN    condition/dynamic_router.go:127 config center does not start, please check if the configuration center has been properly configured in dubbogo.yml
WARN    condition/dynamic_router.go:176 condition router get providerApplication is empty, will not subscribe to provider app rules.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 2dd66e9 into apache:release-3.1 Jan 4, 2024
5 checks passed
@justxuewei justxuewei changed the title Fix:modify router warn log [3.1] Fix:modify router warn log Jan 5, 2024
@FinalT FinalT deleted the fix-router-logs branch January 7, 2024 11:34
FinalT added a commit to FinalT/dubbo-go that referenced this pull request Jan 7, 2024
FinalT added a commit to FinalT/dubbo-go that referenced this pull request Jan 7, 2024
chickenlj pushed a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants