Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1] Fix nacos App Metadata not compatible with java #2563

Merged
merged 3 commits into from
Jan 19, 2024
Merged

[3.1] Fix nacos App Metadata not compatible with java #2563

merged 3 commits into from
Jan 19, 2024

Conversation

FoghostCn
Copy link
Contributor

Fix #2543

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (68e999d) 44.97% compared to head (144b105) 44.96%.

❗ Current head 144b105 differs from pull request most recent head da29d92. Consider uploading reports for the commit da29d92 to get more accurate results

Files Patch % Lines
metadata/report/nacos/report.go 43.75% 7 Missing and 2 partials ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-3.1    #2563      +/-   ##
===============================================
- Coverage        44.97%   44.96%   -0.02%     
===============================================
  Files              273      273              
  Lines            18455    18469      +14     
===============================================
+ Hits              8301     8305       +4     
- Misses            9265     9270       +5     
- Partials           889      894       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

FinalT

This comment was marked as outdated.

Sign in to view

@FoghostCn FoghostCn changed the title Fix nacos App Metadata not compatible with java [3.1] Fix nacos App Metadata not compatible with java Jan 5, 2024
@FoghostCn FoghostCn mentioned this pull request Jan 9, 2024
Closed
@FinalT
Copy link
Member

FinalT commented Jan 10, 2024

LGTM.

@FinalT
Copy link
Member

FinalT commented Jan 10, 2024

Plz backport to main branch after merging.

@FoghostCn
Copy link
Contributor Author

Plz backport to main branch after merging.

OK

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chickenlj chickenlj merged commit 6dba60a into apache:release-3.1 Jan 19, 2024
5 checks passed
@FoghostCn FoghostCn deleted the release-3.1 branch January 22, 2024 02:19
@FoghostCn FoghostCn mentioned this pull request Jan 31, 2024
Open
FoghostCn added a commit to FoghostCn/dubbo-go that referenced this pull request Mar 10, 2024
@FoghostCn
Fix#2543, nacos App Metadata not compatible with java (apache#2563)
76d479f
@FoghostCn FoghostCn mentioned this pull request Mar 10, 2024
Merged
chickenlj pushed a commit that referenced this pull request Mar 10, 2024
@FoghostCn
Fix#2543, nacos App Metadata not compatible with java (#2563) (#2615)
c75b90e
FoghostCn added a commit to FoghostCn/dubbo-go that referenced this pull request Mar 27, 2024
@FoghostCn
Fix#2543, nacos App Metadata not compatible with java (apache#2563) (a…
ef96dd4 
…pache#2615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FinalT FinalT FinalT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FoghostCn @codecov-commenter @FinalT @chickenlj