Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to main branch: nacos App Metadata not compatible with java (#2563) #2615

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

FoghostCn
Copy link
Contributor

Backport nacos App Metadata not compatible with java (#2563)

Fix#2543

@FoghostCn FoghostCn changed the title Backport nacos App Metadata not compatible with java (#2563) Backport to main branch: nacos App Metadata not compatible with java (#2563) Mar 10, 2024
Copy link

sonarcloud bot commented Mar 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 47.76%. Comparing base (b645659) to head (bcc88f9).

❗ Current head bcc88f9 differs from pull request most recent head 76d479f. Consider uploading reports for the commit 76d479f to get more accurate results

Files Patch % Lines
metadata/report/nacos/report.go 43.75% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2615      +/-   ##
==========================================
+ Coverage   47.73%   47.76%   +0.03%     
==========================================
  Files         341      341              
  Lines       24994    25008      +14     
==========================================
+ Hits        11931    11946      +15     
+ Misses      11908    11906       -2     
- Partials     1155     1156       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@FinalT FinalT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit c75b90e into apache:main Mar 10, 2024
5 checks passed
FoghostCn added a commit to FoghostCn/dubbo-go that referenced this pull request Mar 27, 2024
@FoghostCn FoghostCn deleted the nacos-metadata branch April 29, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants