Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metrics and tracing configs #2463

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Update metrics and tracing configs #2463

merged 6 commits into from
Oct 31, 2023

Conversation

chickenlj
Copy link
Contributor

followup of #2447

FoghostCn
FoghostCn reviewed Oct 27, 2023
View reviewed changes
compat.go Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

No Coverage information No Coverage information
10.6% 10.6% Duplication

FoghostCn
FoghostCn approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 689115e into apache:feature-triple Oct 31, 2023
5 of 6 checks passed
@chickenlj chickenlj deleted the metrics-otel-options branch October 31, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoghostCn FoghostCn FoghostCn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chickenlj @FoghostCn