Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2446, move XxxOption definition in global package to separate packages #2447

Merged
merged 7 commits into from
Oct 26, 2023

Conversation

chickenlj
Copy link
Contributor

See #2446 and #2442 for details

registry/options.go Outdated Show resolved Hide resolved
protocol/options.go Show resolved Hide resolved
@@ -0,0 +1,103 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.OtelConfig and config.TracingConfig should be considered well with @ev1lQuark.

metrics/options.go Outdated Show resolved Hide resolved
metadata/options.go Outdated Show resolved Hide resolved
metadata/options.go Outdated Show resolved Hide resolved
logger/options.go Show resolved Hide resolved
config_center/options.go Outdated Show resolved Hide resolved
config_center/options.go Outdated Show resolved Hide resolved
metadata/options.go Outdated Show resolved Hide resolved
config_center/options.go Outdated Show resolved Hide resolved
metrics/options.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chickenlj
Copy link
Contributor Author

There're currently two parts that need to be confirmed:

  1. otel/tracing config
  2. metrics config

I will submit new patches once we reach conclusions. Hopefully, it will be done within this week.

@chickenlj chickenlj merged commit 9d62f72 into apache:feature-triple Oct 26, 2023
4 of 6 checks passed
@chickenlj chickenlj deleted the feature-triple-options branch October 26, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants