Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: config random port #2436

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: config random port #2436

merged 1 commit into from
Oct 9, 2023

Conversation

maguowei
Copy link
Contributor

@maguowei maguowei commented Sep 28, 2023 •
edited
Loading

#2384 is missing a condition check, so it still cannot use random ports.

@chickenlj @AlexStocks

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@maguowei maguowei changed the title fix config random port fix: config random port Sep 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2436 (77a95b0) into main (5ac057d) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head 77a95b0 differs from pull request most recent head ea3d664. Consider uploading reports for the commit ea3d664 to get more accurate results

@@            Coverage Diff             @@
##             main    #2436      +/-   ##
==========================================
- Coverage   45.18%   45.09%   -0.09%     
==========================================
  Files         269      269              
  Lines       18220    18167      -53     
==========================================
- Hits         8233     8193      -40     
+ Misses       9110     9102       -8     
+ Partials      877      872       -5
Files Coverage Δ
config/service_config.go 50.62% <0.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

chickenlj
chickenlj approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit debe37d into apache:main Oct 9, 2023
6 checks passed
@maguowei maguowei deleted the fix-random_port branch October 11, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@chickenlj chickenlj chickenlj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maguowei @codecov-commenter @AlexStocks @chickenlj