fix(config): Random ports can't be assgined #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition of assigning a random port for protocols should be that port is less than or equal to 0, not the length of the port string. Fixes: apache#2382 Signed-off-by: Xuewei Niu <justxuewei@apache.org>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #2384 +/- ##
==========================================
- Coverage 44.40% 44.10% -0.30%
==========================================
Files 305 305
Lines 18618 18623 +5
==========================================
- Hits 8267 8214 -53
- Misses 9482 9546 +64
+ Partials 869 863 -6
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
justxuewei
changed the title
AlexStocks
approved these changes
Aug 16, 2023
maguowei
added a commit
to maguowei/dubbo-go
that referenced
this pull request
Sep 27, 2023
maguowei
added a commit
to maguowei/dubbo-go
that referenced
this pull request
Sep 28, 2023
maguowei
added a commit
to maguowei/dubbo-go
that referenced
this pull request
Sep 28, 2023
chickenlj
pushed a commit
that referenced
this pull request
Oct 9, 2023
maguowei
added a commit
to maguowei/dubbo-go
that referenced
this pull request
Oct 11, 2023
maguowei
added a commit
to maguowei/dubbo-go
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition of assigning a random port for protocols should be that port
is less than or equal to 0, not the length of the port string.
Fixes: #2382