Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rewrite RPC metrics into the event pattern #2392

Merged
merged 14 commits into from
Aug 30, 2023
Merged

refactor: rewrite RPC metrics into the event pattern #2392

merged 14 commits into from
Aug 30, 2023

Conversation

ev1lQuark
Copy link
Contributor

No description provided.

FoghostCn
FoghostCn approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ev1lQuark ev1lQuark mentioned this pull request Aug 28, 2023
Merged
chickenlj
chickenlj approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 0a02805 into apache:main Aug 30, 2023
6 checks passed
@ev1lQuark ev1lQuark mentioned this pull request Aug 31, 2023
Closed
@FoghostCn FoghostCn mentioned this pull request Sep 4, 2023
Merged
@ev1lQuark ev1lQuark deleted the refactor branch September 8, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoghostCn FoghostCn FoghostCn approved these changes

@chickenlj chickenlj chickenlj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ev1lQuark @FoghostCn @chickenlj