Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update metrics sample to fit new design in dubbo-go #599

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

ev1lQuark
Copy link
Contributor

PRs:

TODO:

  • Offer api to let users custom some metrics, dubbo-go metrics module needs to add this feature first.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 541e026 into apache:master Aug 29, 2023
1 check passed
@ev1lQuark ev1lQuark deleted the metrics branch January 21, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants