Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate old RT metric impl to new RT impl #2390

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

FoghostCn
Copy link
Contributor

@FoghostCn FoghostCn commented Aug 21, 2023

migrate old RT metric impl to new RT impl , related to #2376

  1. simplify rt usage
  2. fix: metric tag application -> application_name
  3. fix: dubbo_registry_notify_num_last to metric type gauge

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #2390 (585593a) into main (c9c5a46) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 585593a differs from pull request most recent head a24153b. Consider uploading reports for the commit a24153b to get more accurate results

@@            Coverage Diff             @@
##             main    #2390      +/-   ##
==========================================
+ Coverage   45.05%   45.08%   +0.02%     
==========================================
  Files         306      306              
  Lines       18692    18652      -40     
==========================================
- Hits         8422     8409      -13     
+ Misses       9393     9368      -25     
+ Partials      877      875       -2     
Files Changed Coverage Δ
metrics/api.go 0.00% <0.00%> (ø)
metrics/common.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ev1lQuark ev1lQuark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 14a9b34 into apache:main Aug 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants