-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make rt metric more performance and easy to use #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge histogram summary metric interface to ObservableMetric
Calculate the rt result when Prometheus pulls the data
simplfy prometheus registry and impl rt interface
Lvnszn
reviewed
Aug 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #2376 +/- ##
==========================================
+ Coverage 44.27% 45.00% +0.73%
==========================================
Files 304 306 +2
Lines 18528 18687 +159
==========================================
+ Hits 8203 8410 +207
+ Misses 9467 9404 -63
- Partials 858 873 +15
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Lvnszn
approved these changes
Aug 12, 2023
ev1lQuark
approved these changes
Aug 13, 2023
LGTM |
ev1lQuark
reviewed
Aug 14, 2023
AlexStocks
approved these changes
Aug 16, 2023
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize rt calculation time
The current implementation rt will be calculated every time the sample data is added, which is performance-intensive and unnecessary.
new implementation will only be calculated when Prometheus pulls data
add more unit tests for metrics
add Rt interface to
MetricRegisrty
simplfy rt processingfor example:
it will produce 5 metrics in prometheus: