Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize the integration of otel tracing #2387

Merged
merged 12 commits into from
Aug 28, 2023
Merged

Conversation

ev1lQuark
Copy link
Contributor

@ev1lQuark ev1lQuark commented Aug 18, 2023

Resolves #2386

Features:

  • Simplify the initialization process of the tracing module, by configuration instead of programming
  • Support more tracing exporters, include stdout, Jaeger, Zipkin, and Otlp(a bug to be fixed)
  • Support for the W3C standand and the B3 standard of context propagation
  • Allow user to config sampling probability to achieve a more refined sampling strategy

Bugs:

  • Otlp-grpc use grpc health check which has the namespace conflict with dubbo3 protocol

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2387 (53d65af) into main (bf5f2dd) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 36.76%.

@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
- Coverage   45.00%   44.94%   -0.07%     
==========================================
  Files         306      307       +1     
  Lines       18692    18752      +60     
==========================================
+ Hits         8413     8428      +15     
- Misses       9405     9445      +40     
- Partials      874      879       +5     
Files Changed Coverage Δ
common/extension/otel_trace.go 0.00% <0.00%> (ø)
filter/otel/trace/attachment.go 100.00% <ø> (ø)
config/root_config.go 66.34% <16.66%> (-1.48%) ⬇️
config/otel_config.go 46.51% <46.51%> (ø)
filter/otel/trace/filter.go 71.01% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ev1lQuark ev1lQuark changed the title feat: optimize the integration of otel tracer feat: optimize the integration of otel tracing Aug 22, 2023
@@ -66,6 +66,10 @@ import (
_ "dubbo.apache.org/dubbo-go/v3/metadata/service/remote"
_ "dubbo.apache.org/dubbo-go/v3/metrics/app_info"
_ "dubbo.apache.org/dubbo-go/v3/metrics/prometheus"
_ "dubbo.apache.org/dubbo-go/v3/otel/trace/jaeger"
_ "dubbo.apache.org/dubbo-go/v3/otel/trace/zipkin"
//_ "dubbo.apache.org/dubbo-go/v3/otel/trace/otlp" // FIXME: otlp-grpc use grpc health check which has the namespace conflict with dubbo3 protocol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be fixed by #2395

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chickenlj chickenlj merged commit 727a2d8 into apache:main Aug 28, 2023
6 checks passed
@ev1lQuark ev1lQuark deleted the otel branch September 8, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize the integration of otel tracer
5 participants