fix: health.proto has name conflict with the one in google.golang.org/grpc #2395
Conversation
…/grpc health check in "dubbo.apache.org/dubbo-go/v3/protocol/dubbo3/health/triple_health_v1" conflicts with the one in "google.golang.org/grpc/health/grpc_health_v1". Fixes apache#2394
HubQin
changed the title
| @@ -80,11 +75,11 @@ func (x HealthCheckResponse_ServingStatus) String() string { | |||
| } | |||
|
|
|||
| func (HealthCheckResponse_ServingStatus) Descriptor() protoreflect.EnumDescriptor { | |||
| return file_protocol_dubbo3_health_triple_health_v1_health_proto_enumTypes[0].Descriptor() | |||
| return file_health_proto_enumTypes[0].Descriptor() | |||
There was a problem hiding this comment.
Why is this function changed?
There was a problem hiding this comment.
Is your triple protoc right?
There was a problem hiding this comment.
yes，it is auto-gen by protoc. command to generate:
protoc --go_out=. --go_opt paths=source_relative --go-triple_out=. ./health.proto --go-triple_opt paths=source_relative
|
Btw, you need to add an Apache license for those files. |
|
Kudos, SonarCloud Quality Gate passed!
|
@justxuewei already updated |
Codecov Report
@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
- Coverage 44.85% 44.37% -0.48%
==========================================
Files 307 303 -4
Lines 18786 18411 -375
==========================================
- Hits 8426 8170 -256
+ Misses 9479 9377 -102
+ Partials 881 864 -17 see 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
health check in "dubbo.apache.org/dubbo-go/v3/protocol/dubbo3/health/triple_health_v1" conflicts with the one in "google.golang.org/grpc/health/grpc_health_v1".
Fixes #2394