Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix CI failures after branch adjustment #2280

Merged
merged 2 commits into from
Mar 30, 2023
Merged

ci: Fix CI failures after branch adjustment #2280

merged 2 commits into from
Mar 30, 2023

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Mar 29, 2023 •
edited
Loading

What this PR does:

Which issue(s) this PR fixes:
Fixes #2281

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@justxuewei justxuewei force-pushed the fix/github-action branch 2 times, most recently from 7f21691 to 10e0167 Compare March 29, 2023 13:57
@justxuewei justxuewei changed the title fix(ci): Fix ci failures after branch adjustment fix(ci): Fix CI failures after branch adjustment Mar 29, 2023
This was referenced Mar 29, 2023
Merged
Merged
Merged
@justxuewei justxuewei changed the title fix(ci): Fix CI failures after branch adjustment ci: Fix CI failures after branch adjustment Mar 29, 2023
@justxuewei
ci: Fix CI failures after branch adjustment
34db0b2 
Signed-off-by: Xuewei Niu <justxuewei@apache.org>
@justxuewei
style: Format comments by go 1.20
e9a6e8c 
Go formatter whose version is above 1.19 formats comments as well, see:
https://go.dev/blog/go1.19.

Signed-off-by: Xuewei Niu <justxuewei@apache.org>
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyse. As part of the setup process, we have scanned this repository and found 4 existing alerts. Please check the repository Security tab to see all alerts.

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@3c831fb). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4adffe9 differs from pull request most recent head e9a6e8c. Consider uploading reports for the commit e9a6e8c to get more accurate results

@@           Coverage Diff           @@
##             main    #2280   +/-   ##
=======================================
  Coverage        ?   43.90%           
=======================================
  Files           ?      284           
  Lines           ?    17418           
  Branches        ?        0           
=======================================
  Hits            ?     7647           
  Misses          ?     8963           
  Partials        ?      808

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@justxuewei
Copy link
Member Author

@zhaoyunxing92 I just reverted the Go version upgrade, as it breaks the CI testing somehow. I think we should file an issue and open a pull request to do upgrade.

@justxuewei
Copy link
Member Author

@AlexStocks @zhaoyunxing92 @chickenlj PTAL. The CI issues block all of pull requests for now.

@justxuewei justxuewei merged commit a633946 into apache:main Mar 30, 2023
@justxuewei justxuewei mentioned this pull request Apr 6, 2023
Closed
justxuewei added a commit that referenced this pull request Apr 6, 2023
@justxuewei
Revert "ci: Fix CI failures after branch adjustment (#2280)"
b0a4fff 
This reverts commit a633946.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The CI couldn't work after branch adjustment
3 participants
@justxuewei @codecov-commenter @AlexStocks