-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add subscribe any value #2267
add subscribe any value #2267
Conversation
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
Before #2262 is resolved, please merge the code into "3.0" branch. |
To make sure 3.0 branch always represents the latest stable version, we must restrict only bugfixes can be merged into it to avoid any possible unexpected changes. I suggest merging this patch into the 3.1 feature branch. Let's wait for the branch adjustment to finish first. |
Please pull the latest commits after #2280 is merged to address the CI issues. |
done |
Please follow our format of pull request message: give a brief introduction of what this PR does, and what a issue this PR fixes, see: #2280. |
Codecov Report
@@ Coverage Diff @@
## main #2267 +/- ##
=======================================
Coverage 44.27% 44.27%
=======================================
Files 289 289
Lines 18199 18199
=======================================
Hits 8058 8058
Misses 9293 9293
Partials 848 848 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great works! But a few comments.
Please link an issue that this PR fixes. If there is no issue for this PR, please file one. So the commit message and PR message look like:
Btw, the signed-off message could be generated by git with |
Signed-off-by: wudong <ustbwmd@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks!
Please rebase your PR onto the latest main branch to address the CI failure. |
Kudos, SonarCloud Quality Gate passed! |
@wudong5 pls fix the ci failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What this PR does:
Which issue(s) this PR fixes:
Fixes #2236
Signed-off-by: wudong ustbwmd@163.com