Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rem:gomonkey move #1881

Merged
merged 24 commits into from
May 5, 2022
Merged

Conversation

pherzheyu
Copy link
Contributor

@pherzheyu pherzheyu commented May 5, 2022

What this PR does:

Remove go monkey so ut runs on m1 machine.

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@Lvnszn
Copy link
Contributor

Lvnszn commented May 5, 2022

commit id 能 rebase 掉么。感觉有点多。

@codecov-commenter
Copy link

Codecov Report

Merging #1881 (0c8c8d6) into 3.0 (a24957d) will decrease coverage by 0.63%.
The diff coverage is n/a.

❗ Current head 0c8c8d6 differs from pull request most recent head 6d178b1. Consider uploading reports for the commit 6d178b1 to get more accurate results

@@            Coverage Diff             @@
##              3.0    #1881      +/-   ##
==========================================
- Coverage   45.44%   44.80%   -0.64%     
==========================================
  Files         297      297              
  Lines       17294    17294              
==========================================
- Hits         7859     7749     -110     
- Misses       8593     8722     +129     
+ Partials      842      823      -19     
Impacted Files Coverage Δ
remoting/nacos/builder.go 0.00% <0.00%> (-64.29%) ⬇️
metadata/report/etcd/report.go 1.11% <0.00%> (-32.23%) ⬇️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-15.90%) ⬇️
registry/etcdv3/listener.go 0.00% <0.00%> (-10.00%) ⬇️
registry/etcdv3/registry.go 3.07% <0.00%> (-6.16%) ⬇️
metrics/prometheus/reporter.go 26.85% <0.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a24957d...6d178b1. Read the comment docs.

@pherzheyu
Copy link
Contributor Author

commit id 能 rebase 掉么。感觉有点多。

下次搞掉

@LaurenceLiZhixin LaurenceLiZhixin merged commit ea02d8a into apache:3.0 May 5, 2022
@pherzheyu pherzheyu deleted the feature/monkey-move branch May 5, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants